]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commit
xfs_scrub: drop the warning about mixed bidirectional codepoints in names
authorDarrick J. Wong <djwong@kernel.org>
Mon, 4 May 2026 17:08:52 +0000 (10:08 -0700)
committerAndrey Albershteyn <aalbersh@kernel.org>
Wed, 6 May 2026 09:24:04 +0000 (11:24 +0200)
commit5f5d7fe4a7efbcdb7d046a09b739e78ffa468fdf
treeb624d4ba2f662063d3bd12b93cd03d9e5e5d4ff7
parent1c52b36e3234aedaaa4b467f64c01636e96c1946
xfs_scrub: drop the warning about mixed bidirectional codepoints in names

Gedalya complained about receiving warnings about mixed bidirectional
codepoints in a filename:

"First, well-known file name extensions are not internationalized. While
the file name can be in non-latin letters, the extension will be in
latin. Hence you would expect to see file names such as עברית.pdf ."

Gedalya goes on to point out that file names can be created from (say)
the title of an article, which might itself mix RTL and LTR characters.
Both uses are totally fair, but regrettably unfamiliar to 2018-era me.

Unicode TR 36 even weasel-words its own recommendation: "As much as
possible, avoid mixing right-to-left and left-to-right characters in a
single name."  Maybe I should have paid more attention to weasel
wording in specifications. :P

Let's fix this by removing the warning altogether.

Reported-by: gedalya@gedalya.net
Link: https://lore.kernel.org/linux-xfs/8961ee4a-3830-498b-a432-5545695db599@gedalya.net/
Link: https://www.unicode.org/reports/tr36/tr36-15.html#Bidirectional_Text_Spoofing
Cc: <linux-xfs@vger.kernel.org> # v4.16.0
Fixes: baa9ed8dca213f ("xfs_scrub: check name for suspicious characters")
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Andrey Albershteyn <aalbersh@kernel.org>
scrub/unicrash.c