]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/devicehealth: fix telemetry stops sending device reports after 48 hours
authorYaarit Hatuka <yaarit@redhat.com>
Mon, 27 Jan 2020 13:57:55 +0000 (08:57 -0500)
committerYaarit Hatuka <yaarit@redhat.com>
Mon, 27 Jan 2020 17:01:44 +0000 (12:01 -0500)
commit5f7e4a980a73e8cacb2c9bde47d822a32fb8c440
treec52e16e688750344240b84f092f10c1f32abf0f7
parentdf82a274be103a9dea46e7906eb8b177cac17c6a
mgr/devicehealth: fix telemetry stops sending device reports after 48 hours

Telemetry module fetches device metrics which were scraped in the last
"telemetry interval"*2 (=48 hours by default) by calling
_get_device_metrics() with min_sample. _get_device_metrics() fetches the
metrics from omap and breaks on the first one that is older than
min_sample. But because it fetched in ascending order (from oldest to
newest) it was breaking on the first one it received, if it was older
than the interval above. We need to pass min_sample to get_omap_vals()
so it will start fetching from that value.

Fixes: https://tracker.ceph.com/issues/43837
Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
src/pybind/mgr/devicehealth/module.py