]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Turn off -Wshadow
authorIgor Canadi <icanadi@fb.com>
Thu, 6 Nov 2014 20:01:02 +0000 (12:01 -0800)
committerIgor Canadi <icanadi@fb.com>
Thu, 6 Nov 2014 20:01:02 +0000 (12:01 -0800)
commit5fd33d26f1a2dd6dfbb7e6c4659f5f4e7c5ba6d2
tree3299b45f5c2d8ec98846523c7fa2a0bc47bacbfc
parent9f20395cd618ed41eb6afaba9aa380c209bb4c5d
Turn off -Wshadow

Summary:
So glibc is not -Wshadow-safe, so we need to turn it off :(

      error: ‘int sigaction(int, const sigaction*, sigaction*)’ hides
      constructor for ‘struct sigaction’

The rest of the changes in this diff is that we include .h files under rocksdb namespace, which is a no-no.

Test Plan: compiles now

Reviewers: ljin, yhchiang, rven, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D28413
Makefile
port/stack_trace.cc