]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfstests-dev.git/commit
vfs: Make switch_userns set PR_SET_DUMPABLE
authorRodrigo Campos <rodrigo@sdfg.com.ar>
Tue, 14 Mar 2023 11:45:07 +0000 (12:45 +0100)
committerZorro Lang <zlang@kernel.org>
Tue, 14 Mar 2023 14:52:48 +0000 (22:52 +0800)
commit60de82ed2d23cd4ec81f7e406b036fbca5db4710
tree64157ab01d4dc6fb8bb661abd6a50727b7c53ca1
parentf4f0038d5c48a15b6bd2ff23b2b4723c996de030
vfs: Make switch_userns set PR_SET_DUMPABLE

We need PR_SET_DUMPABLE in order to write the mapping files when
creating a userns. From prctl(2) PR_SET_DUMPABLE is reset when the
process's effective user or group ID is changed.

As we are changing the EUID here, we also reset it to allow creating
nested userns with subsequent switch_users() calls.

This was not causing any issues because we weren't using switch_users()
to create nested userns. Nested userns were created with
userns_fd_cb()/create_userns_hierarchy() that set PR_SET_DUMPABLE.

Future patches will rely on switch_users() to create nested userns. So
this patch fixes that.

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
Reviewed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>
src/vfs/utils.c