]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
Revert "firmware: tegra: bpmp: Use scoped device node handling to simplify error...
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 1 Oct 2024 20:40:25 +0000 (22:40 +0200)
committerThierry Reding <treding@nvidia.com>
Thu, 24 Oct 2024 16:38:07 +0000 (18:38 +0200)
commit61c6fe3d6f0e1606a2219ff8afbac7e5068a5795
treea3a9e85019f7c6c90d0027afd72666c9865f658a
parent9852d85ec9d492ebef56dc5f229416c925758edc
Revert "firmware: tegra: bpmp: Use scoped device node handling to simplify error paths"

This reverts commit 8812b8689ee6 ("firmware: tegra: bpmp: Use scoped
device node handling to simplify error paths") because it was silently
modified by committer during commit process, by moving declaration of
'struct device_node *np' above the initializer/constructor.  Such code
was not intention of the author, is not conforming to cleanup.h code
style and decreases the code readability.

I did not write such code and I did not agree to put my name with such
commit.

Original patch:
https://lore.kernel.org/all/20240816135722.105945-2-krzysztof.kozlowski@linaro.org/

Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
[treding@nvidia.com: shorten subject line]
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/firmware/tegra/bpmp.c