]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfstests-dev.git/commit
xfstests: fix broken redirects in generic/131
authorDave Chinner <dchinner@redhat.com>
Wed, 1 May 2013 08:32:03 +0000 (08:32 +0000)
committerRich Johnston <rjohnston@sgi.com>
Fri, 3 May 2013 14:22:13 +0000 (09:22 -0500)
commit627427bb1bb4007c661a178bbeb4ea0bd0167c6f
tree048fe6754bf301d5fa81f73600b6c6d548951c1f
parente6c6abd6dcacafa778d610451a023ec93c1b352e
xfstests: fix broken redirects in generic/131

generic/131 attempts to kill processes that may no longer exist when
the test finishes and has a broken redirect for the error messages
and they end up in a file named "1" in the xfstests root instead of
/dev/null.

Not only that, the attempts to redirect stderr to stdout in the
middle of the test use incorrect redirect syntax, so they create an
empty file named "1" in the xfstests root...

IOWs, all the redirects in the test are broken. Fix them and clean
up the failure case to use the exit trap to trigger the cleanup
function....

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
tests/generic/131