]> git.apps.os.sepia.ceph.com Git - xfsprogs-dev.git/commit
xfs: fix a use after free in xfs_defer_finish_recovery
authorChristoph Hellwig <hch@lst.de>
Mon, 15 Apr 2024 23:07:44 +0000 (16:07 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 17 Apr 2024 21:06:26 +0000 (14:06 -0700)
commit628b9f6737945c7876faf6012c0edde6405c073f
tree3874d59d683e621ccfc7958821dd2b214f8c64b3
parent5ef5d3286beb5f54fdf86d02e67ec73f815e5fa0
xfs: fix a use after free in xfs_defer_finish_recovery

Source kernel commit: 4f6ac47b55e3ce6e982807928d6074ec105ab66e

dfp will be freed by ->recover_work and thus the tracepoint in case
of an error can lead to a use after free.

Store the defer ops in a local variable to avoid that.

Fixes: 7f2f7531e0d4 ("xfs: store an ops pointer in struct xfs_defer_pending")
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>
libxfs/xfs_defer.c