]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix false removal of tombstone issue in FIFO and kCompactionStyleNone
authorSiying Dong <siying@users.noreply.github.com>
Tue, 15 Aug 2017 19:51:41 +0000 (12:51 -0700)
committerYi Wu <yiwu@fb.com>
Tue, 15 Aug 2017 21:12:19 +0000 (14:12 -0700)
commit62e9418a7096ed368f6f1866eed5aa9fa969a345
tree0dd04fbd7df6bb9555f8a78cf1bf3c33c6c442e2
parent03df818cff11f268e5831e8ed710c90db7e26e84
Fix false removal of tombstone issue in FIFO and kCompactionStyleNone

Summary:
Similar to the bug fixed by https://github.com/facebook/rocksdb/pull/2726, FIFO with compaction and kCompactionStyleNone during user customized CompactFiles() with output level to be 0 can suffer from the same problem. Fix it by leveraging the bottommost_level_ flag.
Closes https://github.com/facebook/rocksdb/pull/2735

Differential Revision: D5626906

Pulled By: siying

fbshipit-source-id: 2b148d0461c61dbd986d74655e384419ae442158
db/compaction.cc
db/db_test.cc