]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
mm/damon/sysfs: check contexts->nr in repeat_call_fn
authorJosh Law <objecting@objecting.org>
Sat, 21 Mar 2026 17:54:26 +0000 (10:54 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 28 Mar 2026 03:48:38 +0000 (20:48 -0700)
commit6557004a8b59c7701e695f02be03c7e20ed1cc15
treead2b97b0f1d75519d085c29f93edada6766d76a4
parent1bfe9fb5ed2667fb075682408b776b5273162615
mm/damon/sysfs: check contexts->nr in repeat_call_fn

damon_sysfs_repeat_call_fn() calls damon_sysfs_upd_tuned_intervals(),
damon_sysfs_upd_schemes_stats(), and
damon_sysfs_upd_schemes_effective_quotas() without checking contexts->nr.
If nr_contexts is set to 0 via sysfs while DAMON is running, these
functions dereference contexts_arr[0] and cause a NULL pointer
dereference.  Add the missing check.

For example, the issue can be reproduced using DAMON sysfs interface and
DAMON user-space tool (damo) [1] like below.

    $ sudo damo start --refresh_interval 1s
    $ echo 0 | sudo tee \
            /sys/kernel/mm/damon/admin/kdamonds/0/contexts/nr_contexts

Link: https://patch.msgid.link/20260320163559.178101-3-objecting@objecting.org
Link: https://lkml.kernel.org/r/20260321175427.86000-4-sj@kernel.org
Link: https://github.com/damonitor/damo
Fixes: d809a7c64ba8 ("mm/damon/sysfs: implement refresh_ms file internal work")
Signed-off-by: Josh Law <objecting@objecting.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [6.17+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/sysfs.c