]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commit
iscsi: don't set default value for trusted_ip_list
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 18 Aug 2021 11:23:44 +0000 (13:23 +0200)
committerDimitri Savineau <savineau.dimitri@gmail.com>
Thu, 19 Aug 2021 13:28:08 +0000 (09:28 -0400)
commit6802b8dddd7f8d1f1c47f4eb3b7dd6a6a48820dc
tree711cfa30aaf5cf743a827a8b38080d4f48c81177
parent8ba6101bbbfaeefb184d835b6e23db8be58d08ea
iscsi: don't set default value for trusted_ip_list

It restricts access to the iSCSI API.
It can be left empty if the API isn't going to be access from outside the
gateway node

Even though this seems to be a limited use case, it's better to leave it
empty by default than having a meaningless default value.

We could make this variable mandatory but that would be a breaking
change. Let's just add a logic in the template in order to set this
variable in the configuration file only if it was specified by users.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1994930
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Co-authored-by: Dimitri Savineau <dsavinea@redhat.com>
group_vars/iscsigws.yml.sample
roles/ceph-iscsi-gw/defaults/main.yml
roles/ceph-iscsi-gw/tasks/common.yml
roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2