]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commit
iscsi: don't set default value for trusted_ip_list
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 18 Aug 2021 11:23:44 +0000 (13:23 +0200)
committerDimitri Savineau <savineau.dimitri@gmail.com>
Thu, 19 Aug 2021 16:06:50 +0000 (12:06 -0400)
commit6892e02a308c41d3319e6f6ae7fb7e390942f608
treef344d4fcfa6722c058c5c99ce88a151bf00171b0
parentafe442a18ff5229a9f9de5a819003feac78f7dc2
iscsi: don't set default value for trusted_ip_list

It restricts access to the iSCSI API.
It can be left empty if the API isn't going to be access from outside the
gateway node

Even though this seems to be a limited use case, it's better to leave it
empty by default than having a meaningless default value.

We could make this variable mandatory but that would be a breaking
change. Let's just add a logic in the template in order to set this
variable in the configuration file only if it was specified by users.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1994930
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Co-authored-by: Dimitri Savineau <dsavinea@redhat.com>
(cherry picked from commit 6802b8dddd7f8d1f1c47f4eb3b7dd6a6a48820dc)
group_vars/iscsigws.yml.sample
roles/ceph-iscsi-gw/defaults/main.yml
roles/ceph-iscsi-gw/tasks/common.yml
roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2