]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
common/rc: re-fix detection of device-mapper/persistent memory incompatibility
authorDarrick J. Wong <djwong@kernel.org>
Wed, 15 Sep 2021 23:42:06 +0000 (16:42 -0700)
committerEryu Guan <guaneryu@gmail.com>
Sun, 26 Sep 2021 12:52:18 +0000 (20:52 +0800)
commit69613c2b0989bef29c8686aaee3ccd7640e73f1c
tree00a4283d08151d85583cd7a5835a563632f4feb2
parent02b9a880aed76a165e07beeaf8574edd4a4af310
common/rc: re-fix detection of device-mapper/persistent memory incompatibility

In commit e05491b3, I tried to resolve false test failures that were
a result of device mapper refusing to change access modes on a block
device that supports the FSDAX access mode.  Unfortunately, I did
not realize that there are two ways that fsdax support can be
detected via sysfs: /sys/block/XXX/queue/dax and /sys/block/XXX/dax/,
so I only added a test for the latter.

As of 5.15-rc1 this doesn't seem to work anymore for some reason.  I
don't know enough about the byzantine world of pmem device driver
initialization, but fsdax mode actually does work even though the
/sys/block/XXX/dax/ path went away.  So clearly we have to detect it
via the other sysfs path.

Fixes: e05491b3 ("common/rc: fix detection of device-mapper/persistent memory incompatibility")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
common/rc