]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
rgw_file: fix zipper crash(es) in RGWCopyObj
authorMatt Benjamin <mbenjamin@redhat.com>
Tue, 10 Nov 2020 22:38:23 +0000 (17:38 -0500)
committerMatt Benjamin <mbenjamin@redhat.com>
Wed, 16 Dec 2020 15:41:00 +0000 (10:41 -0500)
commit6ac2eacf69dee4f9129bf8be37967e47fff630ff
tree90aa9c8e3ac55fb6740afbedf96defc0794f6690
parent71b485f096926891ffa156f08ae8b1543b401c44
rgw_file: fix zipper crash(es) in RGWCopyObj

Instantiate zipper object and bucket handles when called from
rgw_rename().

The current change appears potentially valid, but also suggests
topics for further discussion:

1. redundant object and bucket vars (in req_state and RGWOp)
2. semantic implications std::unique_ptr (e.g., redundant handle
   forks)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
src/rgw/rgw_file.h
src/rgw/rgw_op.cc