]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/orchestrator: fix encrypted flag handling in orch daemon add osd
authorYonatan Zaken <yonatan.zaken@gmail.com>
Mon, 12 Aug 2024 20:00:39 +0000 (23:00 +0300)
committerAdam King <adking@redhat.com>
Tue, 27 Aug 2024 22:04:29 +0000 (18:04 -0400)
commit6b0775fda1961022b7b7f4dad8313531e9ebab58
tree8d153d9b645f939d35b9abe35e1b2a507f7451d1
parent05e246189b65818db1b89dd2dfe61f3e024db86b
mgr/orchestrator: fix encrypted flag handling in orch daemon add osd

The current implementation incorrectly parses this `encrypted` flag as a string rather than a boolean value.
This leads to unintended behavior causing an LVM encryption layer to be created regardless of whether `encrypted=True` or `encrypted=False` is passed.
The only way to prevent this behavior is by omitting the `encrypted` flag entirely.
This change prevents potential errors, aligning the behavior with user expectations.

Fixes: https://tracker.ceph.com/issues/67372
Signed-off-by: Yonatan Zaken <yonatan.zaken@gmail.com>
(cherry picked from commit 42721c03ee6f2c47a20dfb4d40af4f7f7afe6113)
src/pybind/mgr/orchestrator/module.py