]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
common: admin socket catches exception by reference
authorCasey Bodley <cbodley@redhat.com>
Mon, 6 Nov 2023 16:19:44 +0000 (11:19 -0500)
committerCasey Bodley <cbodley@redhat.com>
Mon, 6 Nov 2023 16:19:46 +0000 (11:19 -0500)
commit6b3b3d3ef1fc6c354c30d5cfd683f5341ece53bf
tree5a93a27a5ad305b4e5c16fbd5f4071fc3a0da35d
parentef1d177eb3fd49383537dc108dab47776805a3aa
common: admin socket catches exception by reference

probably not a real bug, but resolves a compiler warning:

src/common/admin_socket.cc: In member function ‘int RaiseHook::parse_signal(std::string&&, ceph::Formatter*, std::ostream&)’:
src/common/admin_socket.cc:869:21: warning: catching polymorphic type ‘class std::invalid_argument’ by value [-Wcatch-value=]
  869 |       } catch (std::invalid_argument) {
      |                     ^~~~~~~~~~~~~~~~

Fixes: https://tracker.ceph.com/issues/63455
Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/common/admin_socket.cc