]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
libceph: fix a osd request memory leak
authorAlex Elder <elder@inktank.com>
Sat, 16 Feb 2013 04:10:17 +0000 (22:10 -0600)
committerAlex Elder <elder@inktank.com>
Wed, 27 Feb 2013 14:09:31 +0000 (08:09 -0600)
commit6b3c5cdf66da552096b165a50dbd5313759a6ea6
treee5aa49327853dafa69802637b9e083af2ef860b6
parent83ca14fdd35821554058e5fd4fa7b118ee504a33
libceph: fix a osd request memory leak

If an invalid layout is provided to ceph_osdc_new_request(), its
call to calc_layout() might return an error.  At that point in the
function we've already allocated an osd request structure, so we
need to free it (drop a reference) in the event such an error
occurs.

The only other value calc_layout() will return is 0, so make that
explicit in the successful case.

This resolves:
    http://tracker.ceph.com/issues/4240

Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
net/ceph/osd_client.c