]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
cephadm: still try to open ports in firewall on redeploy/reconfig
authorAdam King <adking@redhat.com>
Thu, 13 Apr 2023 17:05:11 +0000 (13:05 -0400)
committerAdam King <adking@redhat.com>
Thu, 31 Aug 2023 17:35:13 +0000 (13:35 -0400)
commit6cd0d078df036df9a9591e66c5979b4bb9357b00
tree73c7cb0e4c64a87c0b7c3a4fb682b76bc3b762fd
parentf9d3e6851387a9a38fb3d12fc0bd50bbf1cfaeb5
cephadm: still try to open ports in firewall on redeploy/reconfig

Prior to this patch we were discarding the provided
ports on reconfig and redeploy in order to not fail
thinking there was a port conflict with the instance
of the daemon we were about to reconfig/redeploy. However,
it's still desirable for us to make sure the firewall ports
are open when we do a reconfig/redpeloy, so this refactors
the port handling approach to have it do that but
still avoid checking for port conflicts. It also include
an update of the type signature of deploy_daemon
to the py3 style. That wasn't needed for the change
but since I was added an arugment there I thought we might
as well do it now.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit fdecd66f1306d3bf60780dbd44c9cb8e63b3892a)
src/cephadm/cephadm.py
src/cephadm/tests/test_cephadm.py