]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
osd/: clarify rebuilt_missing_with_deletes and set in init
authorSamuel Just <sjust@redhat.com>
Thu, 30 May 2019 00:31:48 +0000 (17:31 -0700)
committerSamuel Just <sjust@redhat.com>
Fri, 31 May 2019 21:08:48 +0000 (14:08 -0700)
commit6d66072cc431664c12930f962456fac1c3d7316f
treee2bcbaf54898877f0142743c4d93a74b1f0b64c3
parent8c86678ba7f9402f441e5a0903305a2918e2d1b2
osd/: clarify rebuilt_missing_with_deletes and set in init

Updates PeeringState::init to set may_include_deletes_in_missing when
possible to avoid needlessly rebuilding the missing set on the next map.
The previous behavior was also subtly wrong as until the the next map
the osd would be possibly adding deletes to the missing set without the
flag having been set in the missing set on disk

This patch also renames the flag to reflect the fact that it simply
denotes wheter the may_include_deletes_in_missing omap entry needs to be
written out.  This may happen during rebuild_missing_set_with_deletes,
but it'll also happen more commonly during init now.

Signed-off-by: Samuel Just <sjust@redhat.com>
src/osd/PGLog.cc
src/osd/PGLog.h
src/osd/PeeringState.cc
src/test/osd/TestPGLog.cc