]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
test/librados: make sense of LibRadosMiscConnectFailure.ConnectFailure 52535/head
authorIlya Dryomov <idryomov@gmail.com>
Mon, 19 Jun 2023 18:42:46 +0000 (20:42 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 19 Jul 2023 09:49:15 +0000 (11:49 +0200)
commit6e2090d950984b9f4b6bd866cda02a00b8c61ead
treea6a75d82f29adce561bf90551ab8c8b37daaf4f7
parent932507af15ab329272b08d715e185d8ae1e0d860
test/librados: make sense of LibRadosMiscConnectFailure.ConnectFailure

Over the years, with commits 8bc197400d94 ("ceph_test_librados_api_misc:
fix stupid LibRadosMiscConnectFailure.ConnectFailure test") and
f357459e6b15 ("test/librados: modify LibRadosMiscConnectFailure.ConnectFailure
to comply with new seconds unit"), this test has lost its original
meaning.  Any ability to time out is definitely gone since a 1 second
timeout is too high to kick in a normally functioning setup, not to
mention that the timeout was being ballooned to 10 seconds until the
previous commit.

The first connection attempt would normally succeed while the second
one would immediately fail with "cannot identify monitors to contact"
error due do the cluster handle getting recreated.  The 16 iteration
loop is dead code.

This commit just codifies the above to avoid the appearance that this
test has anything to do with timeouts.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 5857cfb900acc7736b9d1d6d18a8ccaaba03c9b0)
src/test/librados/misc.cc