]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
auth/CephxClientHandler: explain why skipping extra_tickets is needed
authorIlya Dryomov <idryomov@gmail.com>
Mon, 29 Mar 2021 11:45:10 +0000 (13:45 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 29 Mar 2021 11:45:10 +0000 (13:45 +0200)
commit707d32a59951aaf7d656b8ceade4b7ec32e02513
tree54e4bc49d63a4a1c9f82f300f890638b57cd0fb5
parent81847bfac8339f3ae9ec246b78f2102e8b80dc1f
auth/CephxClientHandler: explain why skipping extra_tickets is needed

Since nautilus, CEPHX_GET_AUTH_SESSION_KEY shares both the auth ticket
and the service tickets, sparing an extra round-trip to get the service
tickets via CEPHX_GET_PRINCIPAL_SESSION_KEY.  This applies to msgr1 as
well, but we don't take advantage of it on the client side.

However, fixing CephxClientHandler to do the right thing breaks msgr1.
Since msgr1 is on its way out, rather than also fixing MonClient just
document the bug and the current behaviour.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/auth/cephx/CephxClientHandler.cc