]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
cifs: prevent NULL pointer dereference in UTF16 conversion
authorMakar Semyonov <m.semenov@tssltd.ru>
Thu, 4 Sep 2025 12:28:41 +0000 (15:28 +0300)
committerSteve French <stfrench@microsoft.com>
Thu, 4 Sep 2025 16:43:31 +0000 (11:43 -0500)
commit70bccd9855dae56942f2b18a08ba137bb54093a0
treeb3a165f697f4ddcf9bda392999aef504753c51ec
parent91be128b496c0de60a7dceb70d34935a29d38bbd
cifs: prevent NULL pointer dereference in UTF16 conversion

There can be a NULL pointer dereference bug here. NULL is passed to
__cifs_sfu_make_node without checks, which passes it unchecked to
cifs_strndup_to_utf16, which in turn passes it to
cifs_local_to_utf16_bytes where '*from' is dereferenced, causing a crash.

This patch adds a check for NULL 'src' in cifs_strndup_to_utf16 and
returns NULL early to prevent dereferencing NULL pointer.

Found by Linux Verification Center (linuxtesting.org) with SVACE

Signed-off-by: Makar Semyonov <m.semenov@tssltd.ru>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifs_unicode.c