]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix use_after_free bug when underlying FS enables kFSBuffer (#11645)
authorakankshamahajan <akankshamahajan@fb.com>
Thu, 27 Jul 2023 19:02:03 +0000 (12:02 -0700)
committerakankshamahajan <akankshamahajan@fb.com>
Thu, 27 Jul 2023 21:31:15 +0000 (14:31 -0700)
commit732ab9a131851752c8cc3c7e486d88e18ba7bdfa
treeb076924275d3193b08b96689b6ab170ac00dae5e
parent4bef82ad853d18a240568e972e0d90832dc67235
Fix use_after_free bug when underlying FS enables kFSBuffer (#11645)

Summary:
Fix use_after_free bug in async_io MultiReads when underlying FS enabled kFSBuffer. kFSBuffer is when underlying FS pass their own buffer instead of using RocksDB scratch in FSReadRequest
Since it's an experimental feature, added a hack for now to fix the bug.
Planning to make public API change to remove const from the callback as it doesn't make sense to use const.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11645

Test Plan: tested locally

Reviewed By: ltamasi

Differential Revision: D47819907

Pulled By: akankshamahajan15

fbshipit-source-id: 1faf5ef795bf27e2b3a60960374d91274931df8d
HISTORY.md
util/async_file_reader.cc