]> git.apps.os.sepia.ceph.com Git - ceph-build.git/commit
ceph-pr-commits: use origin/master as the base commit 1686/head
authorKefu Chai <kchai@redhat.com>
Fri, 16 Oct 2020 08:26:06 +0000 (16:26 +0800)
committerKefu Chai <kchai@redhat.com>
Mon, 19 Oct 2020 14:49:37 +0000 (22:49 +0800)
commit7334c60057840c291de6e74ed1cc9459b26d5bdb
treec271ef393720ef6233b926d9b2f3605d5b7828d7
parent0a55bf0e5b5aa856a9b6c6d7ea687b766eff747b
ceph-pr-commits: use origin/master as the base commit

instead of using `${sha1}^1...${sha1}^2` use
`origin/master...origin/pr/${ghprbPullId}/head` for getting the range of
commits introduced by a PR. as per `man git-diff`

> "git diff A...B" is equivalent to "git diff $(git-merge-base A B) B".

and `origin/${ghprbTargetBranch}` and `origin/pr/${ghprbPullId}/head` are fetched by
the ghprb-plugin plugin, so it's safe to use them. see
https://plugins.jenkins.io/ghprb/

Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph-pr-commits/build/build