]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix IOError on WAL write doesn't propagate to write group follower
authorYi Wu <yiwu@fb.com>
Tue, 28 Nov 2017 19:40:40 +0000 (11:40 -0800)
committerYi Wu <yiwu@fb.com>
Tue, 28 Nov 2017 20:33:26 +0000 (12:33 -0800)
commit7513f6350539d478fd5c1081a2b8dffabcbb8a08
tree21455814d23b24524e3d10d21d319c914aeb7f21
parent9e47084ce270861e3c4598bbd15798c440527c59
Fix IOError on WAL write doesn't propagate to write group follower

Summary:
This is a simpler version of #3097 by removing all unrelated changes.

Fixing the bug where concurrent writes may get Status::OK while it actually gets IOError on WAL write. This happens when multiple writes form a write batch group, and the leader get an IOError while writing to WAL. The leader failed to pass the error to followers in the group, and the followers end up returning Status::OK() while actually writing nothing. The bug only affect writes in a batch group. Future writes after the batch group will correctly return immediately with the IOError.
Closes https://github.com/facebook/rocksdb/pull/3201

Differential Revision: D6421644

Pulled By: yiwu-arbug

fbshipit-source-id: 1c2a455c5b73f6842423785eb8a9dbfbb191dc0e
HISTORY.md
db/db_impl_write.cc
db/db_write_test.cc
db/write_thread.cc