]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
crimson/osd/pg: set log_entry_update_waiting_on prior to sending requests
authorMatan Breizman <mbreizma@redhat.com>
Mon, 12 May 2025 11:14:47 +0000 (11:14 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Tue, 13 May 2025 13:27:24 +0000 (16:27 +0300)
commit7607cffde9ac5e2f4287e3bba0eaa6be2d0d3da7
tree1a644f83aeb1b8ef323b1cb90294a68709b8f457
parent4e89b997d454991109f8db10547fb791f38389e7
crimson/osd/pg: set log_entry_update_waiting_on prior to sending requests

Before this patch, we would first send the MOSDPGUpdateLogMissing to
all peers and only then insert this rep_tid to log_entry_update_waiting_on.

This could have resulted in race where we receive the reply prior to
actually inserting the rep_tid.
The reply would have been discarded with "reply on unknown tid" (which
is now aborting).
The unhandled reply would have not let submit_error to return and would
keep holding the lock on this obc.

Fixes: https://tracker.ceph.com/issues/71204
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit a2121ebbc8ab7b41f0ffcd724b46ab778aa54efa)
src/crimson/osd/pg.cc