]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
sctp: fix sockets_allocated imbalance after sk_clone()
authorXin Long <lucien.xin@gmail.com>
Fri, 17 Apr 2026 21:09:40 +0000 (17:09 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Apr 2026 03:31:24 +0000 (20:31 -0700)
commit7c9b012d6367a335f1e91da28401a7c612305a46
treeb3f8c26da30d4b81399c06a446ff8ad835ad4f41
parent0db1688072218bfbbfc0bbdee48bc7820da9e3cd
sctp: fix sockets_allocated imbalance after sk_clone()

sk_clone() increments sockets_allocated and sets the socket refcount to 2.
SCTP performs additional accounting in sctp_clone_sock(), so the clone-time
increment must be undone to avoid double counting.

Note we cannot simply remove the SCTP-side increment, because the SCTP
destroy path in sctp_destroy_sock() only decrements sockets_allocated when
sp->ep is set, which may not be true for all failure paths in
sctp_clone_sock().

Fixes: 16942cf4d3e3 ("sctp: Use sk_clone() in sctp_accept().")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/af8d66f928dec3e9fcbee8d4a85b7d5a6b86f515.1776460180.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sctp/socket.c