]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
rgw: RGWCoroutine::call(nullptr) sets retcode=0
authorCasey Bodley <cbodley@redhat.com>
Fri, 23 Aug 2019 17:45:04 +0000 (13:45 -0400)
committerCasey Bodley <cbodley@redhat.com>
Fri, 23 Aug 2019 17:45:06 +0000 (13:45 -0400)
commit7d12a11a14c4a9c8e814b907d83dc07783e11e80
tree718c52a71d16d498b8807968e6305d9e97deb0c1
parentaf4500be869ddb23569ac0bf2e1d5e10b6edd499
rgw: RGWCoroutine::call(nullptr) sets retcode=0

callers generally expect 'yield call(...);' to set retcode with the
result of the given coroutine. it's valid to call() a nullptr, but
that's not always clear at the call site - for example, this critical
piece of code in RGWBucketSyncSingleEntryCR::operate():

      if (sync_status == 0) {
        /* update marker */
        set_status() << "calling marker_tracker->finish(" << entry_marker << ")";
        yield call(marker_tracker->finish(entry_marker));
        sync_status = retcode;
      }

marker_tracker->finish() only returns a coroutine when it needs to flush
the marker; otherwise it returns a nullptr. as a result, 'retcode' may
not be assigned as expected by the call(), and a previous value is
mistakenly returned up the stack

Fixes: https://tracker.ceph.com/issues/41412
Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/rgw_coroutine.cc