]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Avoid sleep in DBTest.GroupCommitTest to fix flakiness
authorAndrew Kryczka <andrewkr@fb.com>
Tue, 22 May 2018 18:58:51 +0000 (11:58 -0700)
committerFacebook Github Bot <facebook-github-bot@users.noreply.github.com>
Tue, 22 May 2018 19:16:25 +0000 (12:16 -0700)
commit7db721b9a60031a29d93443cfff027f662160e0a
treed4f08bc66c74e16736f1264b54f463e9ac49cf61
parentfcb31016e93aedc15af6adade7f36d77041b7a15
Avoid sleep in DBTest.GroupCommitTest to fix flakiness

Summary:
DBTest.GroupCommitTest would often fail when run under valgrind because its sleeps were insufficient to guarantee a group commit had multiple entries. Instead we can use sync point to force a leader to wait until a non-leader thread has enqueued its work, thus guaranteeing a leader can do group commit work for multiple threads.
Closes https://github.com/facebook/rocksdb/pull/3883

Differential Revision: D8079429

Pulled By: ajkr

fbshipit-source-id: 61dc50fad29d2c85547842f681288de60fa29049
db/db_impl_write.cc
db/db_test.cc
db/write_thread.cc