git-server-git.apps.pok.os.sepia.ceph.com Git

Respect lowest_used_cache_tier option for compressed blocks (#13030)

Summary:
If the lowest_used_cache_tier DB option is set to kVolatileTier, skip insertion of compressed blocks into the secondary cache. Previously, these were always inserted into the secondary cache via the InsertSaved() method, leading to pollution of the secondary cache with blocks that would never be read.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13030

Test Plan: Add a new unit test

Reviewed By: pdillinger

Differential Revision: D63329841

Pulled By: anand1976

fbshipit-source-id: 14d2fce2ed309401d9ad4d2e7c356218b6673f7b

author	anand76 <anand1976@users.noreply.github.com>
	Wed, 25 Sep 2024 18:45:51 +0000 (11:45 -0700)
committer	anand76 <anand1976@users.noreply.github.com>
	Thu, 26 Sep 2024 15:52:05 +0000 (08:52 -0700)
commit	84432c6580381be43bbc5a57ed84b1b0c94fde06
tree	f9245391d10fc56061dd8f1aee570986173412d9	tree \| snapshot
parent	56bc1a0e83092c0ff4bb8c3a15b3e395b2e438a3	commit \| diff

cache/secondary_cache_adapter.cc		diff \| blob \| history
cache/tiered_secondary_cache_test.cc		diff \| blob \| history
unreleased_history/bug_fixes/skip_insertion_tiered_sec_cache.md	[new file with mode: 0644]	blob