]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commit
xfsprogs: remove unreachable code in libxfs_inode_alloc
authorEric Sandeen <sandeen@redhat.com>
Sun, 12 Apr 2015 23:33:49 +0000 (09:33 +1000)
committerDave Chinner <david@fromorbit.com>
Sun, 12 Apr 2015 23:33:49 +0000 (09:33 +1000)
commit89b8d422b3d6a6dfe176aed67e5b3e164af20275
treeeaf2ab851e4a12353f6f8e946704b4a18c0ca268
parent609f6bb20b7972c1a68370faea1dcbcf39912e07
xfsprogs: remove unreachable code in libxfs_inode_alloc

This code does:

        if (!ialloc_context && !ip)
                return;

        // if !ip here, ialloc_context must be true

        if (ialloc_context) {
                ...
                if (!ip)
                        error = ENOSPC;
                if (error)
                        return error;
                // if !ip in this block we've returned
        }

        // so (!ip) cannot be true here
        if (!ip)
                error = ENOSPC;

(cherry picked this one out of Coverity reports)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
libxfs/util.c