]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
msg: drain stack before stopping processors to avoid shutdown hang
authorNitzan Mordechai <nmordech@redhat.com>
Tue, 22 Apr 2025 16:23:16 +0000 (16:23 +0000)
committerNitzan Mordechai <nmordech@redhat.com>
Sun, 10 Aug 2025 06:48:49 +0000 (06:48 +0000)
commit8af12ef9d1876e19b753e0a162f69fb04e56b1df
tree0f07ae34854c3a0820255b82f00fd7e843f42133
parentb2db7fccb931cf32b3b1d6c58c2e3a4755d7d954
msg: drain stack before stopping processors to avoid shutdown hang

`AsyncMessenger::shutdown()` called WorkerProcessor::stop() first,
killing the worker threads, then queued a C_drain callback via
stack->drain().  If a worker had already exited its event loop it never
processed the callback, so drain.wait() blocked forever and the monitor
shutdown hung for minutes.

Move stack->drain() ahead of the processors->stop() loop.  With the new
order the workers are still alive to acknowledge the drain.

Fixes: https://tracker.ceph.com/issues/71303
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
(cherry picked from commit 5fbb9c5e464e3a2227f0c4729b2e6a1bc2f6f9d6)
src/msg/async/AsyncMessenger.cc