]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
cmake: require 4.0.0 <= libfmt-dev < 5.0.0
authorKefu Chai <kchai@redhat.com>
Thu, 2 Aug 2018 11:04:30 +0000 (19:04 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 2 Aug 2018 14:14:03 +0000 (22:14 +0800)
commit8df0e40b46d6da88177480e6bdec9a77c5ba3fbf
tree555008ec4ec1c7030158563ced489e89ed7eb5e2
parentf561fb8029ef7dbe2fddce3b0fa2f8ce2bbd2ef3
cmake: require 4.0.0 <= libfmt-dev < 5.0.0

FMT_VERSION is now living in fmt/core.h in libfmt >= 5.0, so we cannot
parse fmt/format.h for libfmt's version anymore. also we don't need
Findfmt.cmake now. because libfmt-dev 4.0 and up is required by seastar,
also it's libfmt-dev 3.x's cmake module which fails to offer fmt::fmt
target. in other words, it's safe to drop libfmt 3.x support. but 5.0.0
is not compatible with seastar, we will have failures like:

In file included from
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/include/seastar/core/aligned_buffer.hh:25:0,
                 from
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/include/seastar/core/reactor.hh:26,
                 from
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/include/seastar/core/alien.hh:35,
                 from
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/src/core/alien.cc:23:
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/include/seastar/core/print.hh:
In function 'seastar::sstring seastar::format(const char*, A&& ...)':
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/include/seastar/core/print.hh:135:10:
error: 'MemoryWriter' is not a member of 'fmt'
     fmt::MemoryWriter out;
          ^~~~~~~~~~~~
/home/smithfarm/src/ceph/smithfarm/ceph/src/seastar/include/seastar/core/print.hh:136:5:
error: 'out' was not declared in this scope
     out.write(fmt, std::forward<A>(a)...);
     ^~~

so, we should build libfmt even if we have libfmt-dev 5.x

Signed-off-by: Kefu Chai <kchai@redhat.com>
cmake/modules/Findc-ares.cmake
cmake/modules/Findfmt.cmake
src/CMakeLists.txt