]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Improve ldb consistency checks (#6802)
authorsdong <siying.d@fb.com>
Fri, 8 May 2020 21:12:18 +0000 (14:12 -0700)
committeranand76 <anand76@devvm1373.frc2.facebook.com>
Mon, 11 May 2020 19:38:50 +0000 (12:38 -0700)
commit8f9cc1091677627264b6cf23e1eb3a3db0643d45
tree6b10f75345026caba7955137bf8019b6de4701c7
parentbfc1b7acf0305958da878ff8641dc73fdf58f1d5
Improve ldb consistency checks (#6802)

Summary:
When using ldb, users cannot turn on force consistency check in most commands, while they cannot use checksonsistnecy with --try_load_options. The change fixes both by:
1. checkconsistency now calls OpenDB() so that it gets all the options loading and sanitized options logic
2. use options.check_consistency_checks = true by default, and add a --disable_consistency_checks to turn it off.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/6802

Test Plan: Add a new unit test. Some manual tests with corrupted DBs.

Reviewed By: pdillinger

Differential Revision: D21388051

fbshipit-source-id: 8d122732d391b426e3982a1c3232a8e3763ffad0
HISTORY.md
db/version_set.cc
include/rocksdb/utilities/ldb_cmd.h
tools/ldb_cmd.cc
tools/ldb_cmd_test.cc
tools/ldb_tool.cc