]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
xfstests btrfs/284: shorten duration, fix output
authorEric Sandeen <sandeen@redhat.com>
Wed, 15 May 2013 12:18:07 +0000 (07:18 -0500)
committerRich Johnston <rjohnston@sgi.com>
Wed, 15 May 2013 12:18:07 +0000 (07:18 -0500)
commit91f87e3b89c0f7350a56d397ba7255d0e3d6b486
tree33a2ebce74a8b84f19ecee0ad550d20f96f2efba
parent92449b7f36aba627adc3b2f11c1184292c5e43c7
xfstests btrfs/284: shorten duration, fix output

test 284 had... some issues.

First, it took so long nobody ran it; so shorten the extent
count by a factor of about 100.

Having fixed that, we see failures in 2 cases; when start or
len is -1, but the golden output file didn't have error
output, as if they should pass.

I'm going to argue that these *should* both fail; start = -1
has no real meaning.  length = -1 might mean "the rest
of the file" but if that's what you really want, just
don't specify -l.

So add failure output for those cases.

Send all command output to $seq.full, in case that changes
in the future; just capture the return value.

Then remove the return value echo on failure (50?) because
who knows when that might change to some other magic value.

Ok, then when defrag actually works, old defrag returned
"20" (because?) but a recent commit changed it to 0.
So accommodate that too.

And remove a stray "HAVE_DEFRAG=1" while we're at it.
That variable is never used.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Josef Bacik <jbacik@fusionio.com>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
tests/btrfs/284 [changed mode: 0644->0755]
tests/btrfs/284.out