]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/cephadm: fix objects_by_names initialization + some improvements
authorRedouane Kachach <rkachach@ibm.com>
Thu, 23 Oct 2025 11:06:08 +0000 (13:06 +0200)
committerRedouane Kachach <rkachach@ibm.com>
Wed, 12 Nov 2025 12:45:34 +0000 (13:45 +0100)
commit92294b7a9df408124bedd7e6e28846a40e8b269a
treeff96315167557870c7e7cd682f55f628997bdcc9
parent2f9b7940e67fcc0f4bfb913ad545bd39e8e32c64
mgr/cephadm: fix objects_by_names initialization + some improvements

This commit include the following changes:

1. Fix objects_by_names initialization as we was using a dict for all
the case including global scoped objects which is not correct. For
those cases an instance of an empty TLSObject must be used.
2. Add sanity checks to the load() method to avoid loading incorrect
and malformed entries.
3. Add some helper functions to avoid code repetition

Fixes: https://tracker.ceph.com/issues/73625
Resolves: rhbz#2404347

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
(cherry picked from commit d06d06fda84363a57fe0c66339fcc2ebd254f4b1)
src/pybind/mgr/cephadm/tests/test_certmgr.py
src/pybind/mgr/cephadm/tlsobject_store.py
src/pybind/mgr/cephadm/tlsobject_types.py