]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfstests-dev.git/commit
common: leave any breadcrumbs when _link_out_file_named can't find the output file
authorDarrick J. Wong <djwong@kernel.org>
Mon, 10 Nov 2025 18:26:17 +0000 (10:26 -0800)
committerZorro Lang <zlang@kernel.org>
Fri, 14 Nov 2025 18:54:37 +0000 (02:54 +0800)
commit927e55a2ae5d647f9dc42be84ecf053901693f89
tree4998b5fa5f792b543744bd0d89c49b94339a2c93
parent28e2a205c8d1694bc71a4247e6fd92bce29d3624
common: leave any breadcrumbs when _link_out_file_named can't find the output file

_link_out_file_named is an obnoxiously complicated helper involving a
perl script embedded inside a bash subshell that does ... a lookup of
some sort involving comparing the comma-separated list in its second
argument against a comma-separated list in a config file that then maps
to an output file suffix.  I don't know what it really does.  The .cfg
file format is undocumented except for the perl script.

This is really irritating every time I have to touch any of these tests
with flexible golden outputs, and I frequently screw up the mapping.
The helper is not very helpful when you do this, because it doesn't even
try to tell you *which* suffix it found, let alone how it got there.

Fix this up so that the .full file gets some diagnostics, even if the
stdout text is "no qualified output".

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
common/rc