]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
crimson/os/seastore: drop != operator and use friend operator==
authorKefu Chai <tchaikov@gmail.com>
Tue, 1 Mar 2022 16:10:32 +0000 (00:10 +0800)
committerKefu Chai <tchaikov@gmail.com>
Sat, 30 Jul 2022 05:02:15 +0000 (13:02 +0800)
commit936481e0a7fb1a6b516685e5163e6b73a21b8dc8
treebdbccd9bbb681c08609b37f1e2981794f0683f8d
parentf7e122e4b8f671e0555855c0a53d9f748a35dcfb
crimson/os/seastore: drop != operator and use friend operator==

C++20 is able to create != from == operator. so drop the != overload.
this helps to address following FTBFS:

/var/ssd/ceph/src/crimson/os/seastore/omap_manager/btree/omap_btree_node_impl.cc:141:19: error: use of overloaded operator '!=' is ambiguous (with operand types 'crimson::os::seastore::omap_manager::StringKVInnerN$
  assert(child_pt != iter_end());
         ~~~~~~~~ ^  ~~~~~~~~~~
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^~~~
/var/ssd/ceph/src/crimson/os/seastore/omap_manager/btree/string_kv_node_layout.h:380:10: note: candidate function
    bool operator==(const iter_t &rhs) const {
         ^

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/crimson/os/seastore/omap_manager/btree/string_kv_node_layout.h