]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
net: avoid nul-deref trying to bind mp to incapable device
authorJakub Kicinski <kuba@kernel.org>
Sat, 4 Apr 2026 00:19:38 +0000 (17:19 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Apr 2026 01:57:56 +0000 (18:57 -0700)
commit944b3b734cfbbe9502274c092bc3b8220764cc92
tree8f05d2cc4a45d8680c17f156b14de395aca18bf5
parentf2777d5cb5c094e20f2323d953b1740baee5f8e8
net: avoid nul-deref trying to bind mp to incapable device

Sashiko points out that we use qops in __net_mp_open_rxq()
but never validate they are null. This was introduced when
check was moved from netdev_rx_queue_restart().

Look at ops directly instead of the locking config.
qops imply netdev_need_ops_lock(). We used netdev_need_ops_lock()
initially to signify that the real_num_rx_queues check below
is safe without rtnl_lock, but I'm not sure if this is actually
clear to most people, anyway.

Fixes: da7772a2b4ad ("net: move mp->rx_page_size validation to __net_mp_open_rxq()")
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20260404001938.2425670-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/netdev_rx_queue.c