]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
usb: ehci-hcd: fix call balance of clocks handling routines
authorVitalii Mordan <mordan@ispras.ru>
Thu, 21 Nov 2024 11:47:00 +0000 (14:47 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2024 15:25:13 +0000 (16:25 +0100)
commit97264eaaba0122a5b7e8ddd7bf4ff3ac57c2b170
tree743d9cadb68358b47fa6d03b7fd86c2046578602
parentcdd30ebb1b9f36159d66f088b61aee264e649d7a
usb: ehci-hcd: fix call balance of clocks handling routines

If the clocks priv->iclk and priv->fclk were not enabled in ehci_hcd_sh_probe,
they should not be disabled in any path.

Conversely, if they was enabled in ehci_hcd_sh_probe, they must be disabled
in all error paths to ensure proper cleanup.

Found by Linux Verification Center (linuxtesting.org) with Klever.

Fixes: 63c845522263 ("usb: ehci-hcd: Add support for SuperH EHCI.")
Cc: stable@vger.kernel.org # ff30bd6a6618: sh: clk: Fix clk_enable() to return 0 on NULL clk
Signed-off-by: Vitalii Mordan <mordan@ispras.ru>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20241121114700.2100520-1-mordan@ispras.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-sh.c