]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix not getting expected injected read error (#12793)
authorHui Xiao <huixiao@fb.com>
Sat, 22 Jun 2024 03:11:57 +0000 (20:11 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Sat, 22 Jun 2024 03:11:57 +0000 (20:11 -0700)
commit981fd432fa2441fc10a59a462bd14906ccb1c0e0
tree857b78203e97a08bbca8659e2568a3c489cdc5b2
parentd6cf9de9d9153f9eed94dcff0239760ddf6e0888
Fix not getting expected injected read error (#12793)

Summary:
**Context/Summary:**

https://github.com/facebook/rocksdb/pull/12713 accidentally removed the mechanism of ignoring injected read error on non-critical read path such as read from filter. IO failure in read from filter should not fail the read as we can always read from the actual file. Therefore error injection in filter read path does not need to lead to failure in Get() and crash test should allow that. Otherwise, we will get crash test error "Didn't get expected error from..."

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12793

Test Plan: CI

Reviewed By: cbi42

Differential Revision: D58895393

Pulled By: hx235

fbshipit-source-id: 5b605d8446e0b8d4149cdbe6f4be3c7534d4acfa
db_stress_tool/no_batched_ops_stress.cc