]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
spi: mpc52xx: Add cancel_work_sync before module remove
authorPei Xiao <xiaopei01@kylinos.cn>
Thu, 28 Nov 2024 08:38:17 +0000 (16:38 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 2 Dec 2024 00:29:46 +0000 (00:29 +0000)
commit984836621aad98802d92c4a3047114cf518074c8
tree40233ba7b5d156f17c9164df1196bd8b72f4baa1
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
spi: mpc52xx: Add cancel_work_sync before module remove

If we remove the module which will call mpc52xx_spi_remove
it will free 'ms' through spi_unregister_controller.
while the work ms->work will be used. The sequence of operations
that may lead to a UAF bug.

Fix it by ensuring that the work is canceled before proceeding with
the cleanup in mpc52xx_spi_remove.

Fixes: ca632f556697 ("spi: reorganize drivers")
Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://patch.msgid.link/1f16f8ae0e50ca9adb1dc849bf2ac65a40c9ceb9.1732783000.git.xiaopei01@kylinos.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mpc52xx.c