]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix MultiGet crash when no_block_cache is set (#5991)
authoranand76 <anand76@devvm1373.frc2.facebook.com>
Thu, 7 Nov 2019 20:00:45 +0000 (12:00 -0800)
committeranand76 <anand76@devvm1373.frc2.facebook.com>
Tue, 12 Nov 2019 18:56:03 +0000 (10:56 -0800)
commit98e5189fb019b15c9f90c8a468a79543d274bfe5
treeb0233941b1beaf7ba53f4bea2f2af047f480b205
parent3353b7141ddc85607e4236a8fb5078d2260b6671
Fix MultiGet crash when no_block_cache is set (#5991)

Summary:
This PR fixes https://github.com/facebook/rocksdb/issues/5975. In ```BlockBasedTable::RetrieveMultipleBlocks()```, we were calling ```MaybeReadBlocksAndLoadToCache()```, which is a no-op if neither uncompressed nor compressed block cache are configured.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5991

Test Plan:
1. Add unit tests that fail with the old code and pass with the new
2. make check and asan_check

Cc spetrunia

Differential Revision: D18272744

Pulled By: anand1976

fbshipit-source-id: e62fa6090d1a6adf84fcd51dfd6859b03c6aebfe
HISTORY.md
db/db_basic_test.cc
table/block_based/block_based_table_reader.cc