]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/orchestrator: ignore Liskov substitution principle violation
authorSebastian Wagner <sebastian.wagner@suse.com>
Mon, 18 Jan 2021 15:27:18 +0000 (16:27 +0100)
committerSebastian Wagner <sebastian.wagner@suse.com>
Tue, 19 Jan 2021 10:33:14 +0000 (11:33 +0100)
commit9923d2a1193c374b9c2e00b5ee69023cb72a9f00
treec48a95de8754774944c9a840d73ca0bdb05fac31
parentc95ba878c66aae44816b1451049449685d444f0a
mgr/orchestrator: ignore Liskov substitution principle violation

Right now, we're violating the Liskov substitution principle by deriving from `Orchestrator` but `process` takes a sub class of `Completion`:
See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides

The idea is to make Orchestrator a type constructor with `CompletionT` as argument, but this is not supported by mypy: https://github.com/python/typing/issues/548

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/rook/module.py
src/pybind/mgr/test_orchestrator/module.py