]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd
authorSridhar Seshasayee <sseshasa@redhat.com>
Fri, 27 May 2022 08:59:07 +0000 (14:29 +0530)
committerSridhar Seshasayee <sseshasa@redhat.com>
Mon, 30 May 2022 13:10:42 +0000 (18:40 +0530)
commit9a0d42c9fbcf64711a791edcf9cafdba57d901d7
tree1015290560bc67a9b3f61081a557687274bf5e50
parentca5eaaae9c27be864787c76b5e30fd2fe17c16d1
mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd

Before proceeding to handle "osd new" mon command as part of
OSDMonitor::prepare_command_impl(), a check is made to verify if the
authmon is writeable. Later on, prepare_command_osd_new() invokes
KVMonitor::do_osd_new() to create pending dmcrypt keys and calls
propose_pending(). The propose could fail (with an assertion failure)
if there was a prior mon command that resulted in the kvmon invoking
propose_pending().

In order to avoid such a situation, introduce a check to verify that
kvmon is also writeable in OSDMonitor::prepare_command_impl(). If it
is not writeable, the op is pushed into the wait_for_active context
queue to be retried later.

Fixes: https://tracker.ceph.com/issues/55773
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
src/mon/OSDMonitor.cc