]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/dashboard: fix host form issues
authorNizamudeen A <nia@redhat.com>
Fri, 22 Nov 2024 12:54:42 +0000 (18:24 +0530)
committerNizamudeen A <nia@redhat.com>
Wed, 5 Feb 2025 16:03:11 +0000 (21:33 +0530)
commit9bc969b34c989f1539d4b793c19711782fc4f828
tree334afb9b1103299324f6ca8d7a52c1dc71e354e7
parentc459ea8b74df846d6218dff70428d20a093e5f98
mgr/dashboard: fix host form issues

Addressing the review comments in https://github.com/ceph/ceph/pull/60355#pullrequestreview-2391335490

Issues fixing
 - cluster expansion host form not closing form when submitting it
 - cluster expansion host form changing the location when closing it
 - put the helper text inside helper component since its longer
 - maintenance field should be hidden in cluster expansion form since
   its not a valid option while expanding a cluster. We already add host
   in _no_schedule

Fixes: https://tracker.ceph.com/issues/69020
Signed-off-by: Nizamudeen A <nia@redhat.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/cluster.module.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-form/host-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-form/host-form.component.ts