]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Fix some minor issues in the Customizable infrastructure (#8566)
authormrambacher <mrambach@gmail.com>
Thu, 19 Aug 2021 17:09:30 +0000 (10:09 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Thu, 19 Aug 2021 17:10:47 +0000 (10:10 -0700)
commit9eb002fcf033f6e980448cc655df6aac3a9cc804
treecb740f8e3b559abf80dd8a56f45b5c8bf0dd93a0
parentc625b8d017d43d0bceffbd7c0cf039708578fd1f
Fix some minor issues in the Customizable infrastructure (#8566)

Summary:
- Fix issue with OptionType::Vector when the nested item is a Customizable with no names
- Fix issue with OptionType::Vector to appropriately wrap the elements in a Vector;
- Fix an issue with nested Customizable object with a null immutable object still appearing in the mutable options;
- Fix/Add tests for null/empty customizable objects
- Move the RegisterTestObjects from customizable_test into testutil.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8566

Reviewed By: zhichao-cao

Differential Revision: D30303724

Pulled By: mrambacher

fbshipit-source-id: 33fa8ea2a3b663210cb356da05e64aab7585b1b5
13 files changed:
HISTORY.md
include/rocksdb/configurable.h
include/rocksdb/utilities/customizable_util.h
include/rocksdb/utilities/options_type.h
options/configurable.cc
options/configurable_helper.h
options/customizable.cc
options/customizable_test.cc
options/options_helper.cc
options/options_test.cc
table/mock_table.h
test_util/testutil.cc
test_util/testutil.h