]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commit
erofs: fix incorrect symlink detection in fast symlink
authorGao Xiang <hsiangkao@linux.alibaba.com>
Mon, 9 Sep 2024 03:19:11 +0000 (11:19 +0800)
committerGao Xiang <hsiangkao@linux.alibaba.com>
Mon, 9 Sep 2024 16:45:13 +0000 (00:45 +0800)
commit9ed50b8231e37b1ae863f5dec8153b98d9f389b4
tree79db5b6ae23f8641f02e8e1d37b58ee60e66c74f
parentda3ea35007d0af457a0afc87e84fddaebc4e0b63
erofs: fix incorrect symlink detection in fast symlink

Fast symlink can be used if the on-disk symlink data is stored
in the same block as the on-disk inode, so we don’t need to trigger
another I/O for symlink data.  However, currently fs correction could be
reported _incorrectly_ if inode xattrs are too large.

In fact, these should be valid images although they cannot be handled as
fast symlinks.

Many thanks to Colin for reporting this!

Reported-by: Colin Walters <walters@verbum.org>
Reported-by: https://honggfuzz.dev/
Link: https://lore.kernel.org/r/bb2dd430-7de0-47da-ae5b-82ab2dd4d945@app.fastmail.com
Fixes: 431339ba9042 ("staging: erofs: add inode operations")
[ Note that it's a runtime misbehavior instead of a security issue. ]
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240909031911.1174718-1-hsiangkao@linux.alibaba.com
fs/erofs/inode.c