]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commit
Re-add retired mempurge flag definitions for legacy-options-file temporary support...
authorBaptiste Lemaire <blemaire@fb.com>
Wed, 11 Aug 2021 23:04:19 +0000 (16:04 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Wed, 11 Aug 2021 23:07:30 +0000 (16:07 -0700)
commita53563d86ec6cca1b60e58e0444d2beda99c689e
treea94398fbf1eb74a37dd782a3d0a04b542cf1d018
parent6450e9fc38572b13c9b87021d0011c932e5550f2
Re-add retired mempurge flag definitions for legacy-options-file temporary support. (#8650)

Summary:
Current internal regression tests pass in an old option flag `experimental_allow_mempurge` to a more recently built db.
This flag was retired and removed in a recent PR (https://github.com/facebook/rocksdb/issues/8628), and therefore, the following error comes up : `Failed: Invalid argument: Could not find option: : experimental_allow_mempurge`.
In this PR, I reintroduce the two flags retired in https://github.com/facebook/rocksdb/issues/8628, `experimental_allow_mempurge` and `experimental_mempurge_policy` in `db_options.cc` and mark them both as `kDeprecated`.
This is a temporary fix to save us time to find a long term solution, which hopefully will consist in ignoring options prefixed with `experimental_` that are no longer recognized.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8650

Reviewed By: pdillinger

Differential Revision: D30257307

Pulled By: bjlemaire

fbshipit-source-id: 35303655fd2dd9789fd9e3c450e9d8009f3c1f54
options/db_options.cc