]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commit
mgr/rbd_support: level_spec is optional for schedule list/status
authorIlya Dryomov <idryomov@gmail.com>
Sat, 29 Jan 2022 14:01:27 +0000 (15:01 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Sun, 30 Jan 2022 13:22:35 +0000 (14:22 +0100)
commita5eef01e9248b09c187fcb8c6d122fd08dc54c88
tree24df7750cdbbba0185e736533b4dac0872eaf9f2
parent2f5faabf4258ec37984f871f46fee73e630c8a33
mgr/rbd_support: level_spec is optional for schedule list/status

Commit fea6fdff4c74 ("mgr/rbd_support: level_spec passed to some
commands is not optional") is wrong.  While it is true that a valid
level_spec is needed to create a LevelSpec instance, an empty string
is very much a valid level spec -- it signifies "all levels".

This wasn't caught because within Ceph these commands are wrapped by
rbd CLI which injects an empty string in get_level_spec_args().

Fixes: https://tracker.ceph.com/issues/54058
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
qa/workunits/rbd/cli_generic.sh
src/pybind/mgr/rbd_support/module.py