]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commit
ALSA: hda/realtek: Sequence GPIO2 on Star Labs StarFighter
authorSean Rhodes <sean@starlabs.systems>
Sun, 15 Mar 2026 20:11:27 +0000 (20:11 +0000)
committerTakashi Iwai <tiwai@suse.de>
Mon, 16 Mar 2026 17:04:00 +0000 (18:04 +0100)
commita6919f2a01f8fbf807b015e5b26aecae7db8117b
treed698cc34a9e6cdde71d6c380b43846fa844b8b2e
parent793b008cd39516385791a1d1d223d817e947a471
ALSA: hda/realtek: Sequence GPIO2 on Star Labs StarFighter

The initial StarFighter quirk fixed the runtime suspend pop by muting
speakers in the shutup callback before power-down. Further hardware
validation showed that the speaker path is controlled directly by LINE2
EAPD on NID 0x1b together with GPIO2 for the external amplifier.

Replace the shutup-delay workaround with explicit sequencing of those
controls at playback start and stop:
- assert LINE2 EAPD and drive GPIO2 high on PREPARE
- deassert LINE2 EAPD and drive GPIO2 low on CLEANUP

This avoids the runtime suspend pop without a sleep, and also fixes pops
around G3 entry and display-manager start that the original workaround
did not cover.

Fixes: 1cb3c20688fc ("ALSA: hda/realtek: Fix speaker pop on Star Labs StarFighter")
Tested-by: Sean Rhodes <sean@starlabs.systems>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Link: https://patch.msgid.link/20260315201127.33744-1-sean@starlabs.systems
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/realtek/alc269.c